Re: [PATCH] gnss: core: added logging statement when kfifo_alloc fails

[Joe Perches]

On Tue, 2019-07-09 at 19:14 -0400, Keyur Patel wrote:
> Added missing logging statement when kfifo_alloc fails, to improve
> debugging.\

Nack

> diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c
[]
> @@ -256,6 +256,7 @@ struct gnss_device *gnss_allocate_device(struct device *parent)
>  
>  	ret = kfifo_alloc(&gdev->read_fifo, GNSS_READ_FIFO_SIZE, GFP_KERNEL);
>  	if (ret)
> +		pr_err("kfifo_alloc failed\n");
>  		goto err_put_device;

c is not python.
This will not do what you might expect.
 
>  	gdev->write_buf = kzalloc(GNSS_WRITE_BUF_SIZE, GFP_KERNEL);