Re: [PATCH] tipc: ensure skb->lock is initialised

[Eric Dumazet]

On 7/9/19 10:15 PM, Jon Maloy wrote:
> 
> It is not only for lockdep purposes, -it is essential.  But please provide details about where you see that more fixes are needed.
> 

Simple fact that you detect a problem only when skb_queue_purge() is called should talk by itself.

As I stated, there are many places where the list is manipulated _without_ its spinlock being held.

You want consistency, then 

- grab the spinlock all the time.
- Or do not ever use it.

Do not initialize the spinlock just in case a path will use skb_queue_purge() (instead of using __skb_queue_purge())