Re: [PATCH] arm64/sve: fix genksyms generation
From: Will Deacon
Date: Wed Jul 10 2019 - 04:15:25 EST
Hi Laura, [+Masahiro]
On Tue, Jul 09, 2019 at 03:06:49PM -0400, Laura Abbott wrote:
> On 6/18/19 10:15 AM, Arnd Bergmann wrote:
> > On Tue, Jun 18, 2019 at 2:03 PM Will Deacon <will.deacon@xxxxxxx> wrote:
> > > From 6e004b8824d4eb6a4e61cd794fbc3a761b50135b Mon Sep 17 00:00:00 2001
> > > From: Will Deacon <will.deacon@xxxxxxx>
> > > Date: Tue, 18 Jun 2019 12:56:49 +0100
> > > Subject: [PATCH] genksyms: Teach parse about __uint128_t built-in type
> > >
> > > __uint128_t crops up in a few files that export symbols to modules, so
> > > teach genksyms about it so that we don't end up skipping the CRC
> > > generation for some symbols due to the parser failing to spot them:
> > >
> > > | WARNING: EXPORT symbol "kernel_neon_begin" [vmlinux] version
> > > | generation failed, symbol will not be versioned.
> > > | ld: arch/arm64/kernel/fpsimd.o: relocation R_AARCH64_ABS32 against
> > > | `__crc_kernel_neon_begin' can not be used when making a shared
> > > | object
> > > | ld: arch/arm64/kernel/fpsimd.o:(.data+0x0): dangerous relocation:
> > > | unsupported relocation
> > >
> > > Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> > > Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> > > Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
> >
> > Looks good to me,
> >
> > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > I've added this to my randconfig build setup, replacing my earlier
> > patch, and will let you know if any problems with it remain.
> >
>
> I just hit this on 5ad18b2e60b75c7297a998dea702451d33a052ed on Linus'
> branch. The fix works for me (feel free to add Tested-by). Is this
> already queued up for Linus?
I think there's a fix queued via the kbuild tree:
https://lkml.kernel.org/r/CAK7LNAQRMnovWQA0F8A6mEqDjPxXOGM-1AHoyh1gQa367f+FqQ@xxxxxxxxxxxxxx
Will