Re: [PATCH net-next v3] net/mlx5e: Convert single case statement switch statements into if statements

From: Leon Romanovsky
Date: Wed Jul 10 2019 - 05:31:47 EST


On Tue, Jul 09, 2019 at 11:06:15PM -0700, Nathan Chancellor wrote:
> During the review of commit 1ff2f0fa450e ("net/mlx5e: Return in default
> case statement in tx_post_resync_params"), Leon and Nick pointed out
> that the switch statements can be converted to single if statements
> that return early so that the code is easier to follow.
>
> Suggested-by: Leon Romanovsky <leon@xxxxxxxxxx>
> Suggested-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> ---

Thanks again,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>