Re: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable

From: Jason Gunthorpe
Date: Wed Jul 10 2019 - 12:58:23 EST


On Wed, Jul 10, 2019 at 04:54:33PM +0000, Marciniszyn, Mike wrote:
> > Subject: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
> >
> > I can't think of any reason for the inner variable declaration, so
> > remove it to avoid the issue.
> >
>
> I agree!
>
> > Fixes: 239b0e52d8aa ("IB/hfi1: Move rvt_cq_wc struct into uapi directory")
>
> Thanks for catching this!
>
> Acked-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>

Thanks, I'm going to take Nathan's identical patch though, it arrived
first

Jason