RE: [PATCH] ahci: Remove the exporting of ahci_em_messages

From: Liu, Chuansheng
Date: Wed Jul 10 2019 - 21:03:56 EST




> -----Original Message-----
> From: Denis Efremov [mailto:efremov@xxxxxxxxx]
> Sent: Wednesday, July 10, 2019 11:29 PM
> To: Liu, Chuansheng <chuansheng.liu@xxxxxxxxx>
> Cc: Denis Efremov <efremov@xxxxxxxxx>; Jens Axboe <axboe@xxxxxxxxx>;
> linux-ide@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] ahci: Remove the exporting of ahci_em_messages
>
> The variable ahci_em_messages is declared static and marked
> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
> variable is not used outside of the drivers/ata/libahci.c file it is
> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.

Sounds good to me, thanks.
Reviewed-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxxxxxxxx>