Re: [PATCH v4 3/4] mm: account nr_isolated_xxx in [isolate|putback]_lru_page

From: Johannes Weiner
Date: Thu Jul 11 2019 - 14:07:50 EST


On Thu, Jul 11, 2019 at 10:25:27AM +0900, Minchan Kim wrote:
> The isolate counting is pecpu counter so it would be not huge gain
> to work them by batch. Rather than complicating to make them batch,
> let's make it more stright-foward via adding the counting logic
> into [isolate|putback]_lru_page API.
>
> * v1
> * fix accounting bug - Hillf
>
> Link: http://lkml.kernel.org/r/20190531165927.GA20067@xxxxxxxxxxx
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>
> Suggested-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx>

This is tricky to review, but fwiw it looks correct to me.

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>