Re: [PATCH 1/2] ASoC: samsung: odroid: fix an use-after-free issue for codec

From: Markus Elfring
Date: Sun Jul 14 2019 - 04:48:58 EST


> @@ -317,6 +316,7 @@ static int odroid_audio_probe(struct platform_device *pdev)

> goto err_put_clk_i2s;

> }

>

> + of_node_put(codec);


I would prefer to avoid a bit of duplicate source code also at this place.
Thus I would find a statement like âgoto put_node;â more appropriate here.


> return 0;

>

> err_put_clk_i2s:



Regards,
Markus