Re: [PATCH v4 5/5] Input: hv: Remove dependencies on PAGE_SIZE for ring buffer

From: Dmitry Torokhov
Date: Sun Jul 14 2019 - 19:29:01 EST


On Fri, Jul 12, 2019 at 08:30:27AM +0000, Maya Nakamura wrote:
> Define the ring buffer size as a constant expression because it should
> not depend on the guest page size.
>
> Signed-off-by: Maya Nakamura <m.maya.nakamura@xxxxxxxxx>
> Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>

Applied, thank you.

> ---
> drivers/input/serio/hyperv-keyboard.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv-keyboard.c
> index 8e457e50f837..88ae7c2ac3c8 100644
> --- a/drivers/input/serio/hyperv-keyboard.c
> +++ b/drivers/input/serio/hyperv-keyboard.c
> @@ -75,8 +75,8 @@ struct synth_kbd_keystroke {
>
> #define HK_MAXIMUM_MESSAGE_SIZE 256
>
> -#define KBD_VSC_SEND_RING_BUFFER_SIZE (10 * PAGE_SIZE)
> -#define KBD_VSC_RECV_RING_BUFFER_SIZE (10 * PAGE_SIZE)
> +#define KBD_VSC_SEND_RING_BUFFER_SIZE (40 * 1024)
> +#define KBD_VSC_RECV_RING_BUFFER_SIZE (40 * 1024)
>
> #define XTKBD_EMUL0 0xe0
> #define XTKBD_EMUL1 0xe1
> --
> 2.17.1
>

--
Dmitry