Re: [PATCH 18/22] objtool: Refactor jump table code
From: Peter Zijlstra
Date: Mon Jul 15 2019 - 05:39:56 EST
On Sun, Jul 14, 2019 at 07:37:13PM -0500, Josh Poimboeuf wrote:
> Now that C jump tables are supported, call them "jump tables" instead of
> "switch tables". Also rename some other variables, add comments, and
> simplify the code flow a bit.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> ---
> tools/objtool/check.c | 82 +++++++++++++++++++++++--------------------
> tools/objtool/elf.c | 2 +-
> tools/objtool/elf.h | 2 +-
> 3 files changed, 46 insertions(+), 40 deletions(-)
>
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index a190a6e79a91..b21e9f7768d0 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -627,7 +627,7 @@ static int add_jump_destinations(struct objtool_file *file)
> * However this code can't completely replace the
> * read_symbols() code because this doesn't detect the
> * case where the parent function's only reference to a
> - * subfunction is through a switch table.
> + * subfunction is through a switch jump table.
s/switch// ?