Re: [PATCH v18 11/15] IB/mlx4: untag user pointers in mlx4_get_umem_mr

From: Jason Gunthorpe
Date: Mon Jul 15 2019 - 14:05:15 EST


On Mon, Jul 15, 2019 at 06:01:29PM +0200, Andrey Konovalov wrote:
> On Mon, Jun 24, 2019 at 7:40 PM Catalin Marinas <catalin.marinas@xxxxxxx> wrote:
> >
> > On Mon, Jun 24, 2019 at 04:32:56PM +0200, Andrey Konovalov wrote:
> > > This patch is a part of a series that extends kernel ABI to allow to pass
> > > tagged user pointers (with the top byte set to something else other than
> > > 0x00) as syscall arguments.
> > >
> > > mlx4_get_umem_mr() uses provided user pointers for vma lookups, which can
> > > only by done with untagged pointers.
> > >
> > > Untag user pointers in this function.
> > >
> > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
> > > drivers/infiniband/hw/mlx4/mr.c | 7 ++++---
> > > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> >
> > This patch also needs an ack from the infiniband maintainers (Jason).
>
> Hi Jason,
>
> Could you take a look and give your acked-by?

Oh, I think I did this a long time ago. Still looks OK. You will send
it?

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>

Jason