Re: [PATCH 2/8] leds: as3645a: Fix misuse of strlcpy

From: Jacek Anaszewski
Date: Mon Jul 15 2019 - 14:30:05 EST


Hi Joe,

Thank you for the patch.

On 7/5/19 1:57 AM, Joe Perches wrote:
> Probable cut&paste typo - use the correct field size.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/leds/leds-as3645a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index 14ab6b0e4de9..050088dff8dd 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -668,7 +668,7 @@ static int as3645a_v4l2_setup(struct as3645a *flash)
> };
>
> strlcpy(cfg.dev_name, led->name, sizeof(cfg.dev_name));
> - strlcpy(cfgind.dev_name, flash->iled_cdev.name, sizeof(cfg.dev_name));
> + strlcpy(cfgind.dev_name, flash->iled_cdev.name, sizeof(cfgind.dev_name));
>
> flash->vf = v4l2_flash_init(
> &flash->client->dev, flash->flash_node, &flash->fled, NULL,
>

Applied to for-5.4 branch of linux-leds.git.

--
Best regards,
Jacek Anaszewski