Re: [PATCH] extcon: sm5502: Add IRQ_ONESHOT

From: Chanwoo Choi
Date: Wed Jul 24 2019 - 06:31:29 EST


On 19. 7. 20. ìì 1:28, Vasyl Gomonovych wrote:
> Do not fire irq again until thread done
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@xxxxxxxxx>
> ---
> Can you please look on this from false positives point of view
> ---
> drivers/extcon/extcon-sm5502.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
> index 98e4f616b8f1..dc43847ad2b0 100644
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -597,7 +597,7 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c,
>
> ret = devm_request_threaded_irq(info->dev, virq, NULL,
> sm5502_muic_irq_handler,
> - IRQF_NO_SUSPEND,
> + IRQF_NO_SUSPEND | IRQF_ONESHOT,
> muic_irq->name, info);
> if (ret) {
> dev_err(info->dev,
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics