Re: [PATCH v1 5/6] mt76: fix some checkpatch warnings

From: Joe Perches
Date: Wed Jul 24 2019 - 07:03:52 EST


On Wed, 2019-07-24 at 16:58 +0800, Ryder Lee wrote:
> This fixes the following checkpatch warnings:
[]
> diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c
[]
> @@ -74,15 +75,14 @@ mt76_rx_aggr_check_release(struct mt76_rx_tid *tid, struct sk_buff_head *frames)
> for (idx = (tid->head + 1) % tid->size;
> idx != start && nframes;
> idx = (idx + 1) % tid->size) {
> -
> skb = tid->reorder_buf[idx];
> if (!skb)
> continue;
>
> nframes--;
> - status = (struct mt76_rx_status *) skb->cb;
> + status = (struct mt76_rx_status *)skb->cb;
> if (!time_after(jiffies, status->reorder_time +
> - REORDER_TIMEOUT))
> + REORDER_TIMEOUT))

trivia/bikeshedding: perhaps better slightly differently:

if (!time_after(jiffies,
status->reorder_time + REORDER_TIMEOUT))