[tip:x86/cleanups] x86/crash: Remove unnecessary comparison

From: tip-bot for Nikolas Nyby
Date: Wed Jul 24 2019 - 10:55:37 EST


Commit-ID: 4599c6671b8119ed5455e4ed6b967b461c27a9f7
Gitweb: https://git.kernel.org/tip/4599c6671b8119ed5455e4ed6b967b461c27a9f7
Author: Nikolas Nyby <nikolas@xxxxxxx>
AuthorDate: Wed, 24 Jul 2019 00:13:37 -0400
Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
CommitDate: Wed, 24 Jul 2019 16:50:15 +0200

x86/crash: Remove unnecessary comparison

The ret comparison and return are unnecessary as of commit f296f2634920
("x86/kexec: Remove walk_iomem_res() call with GART type")

elf_header_exclude_ranges() returns ret in any case, with or without this
comparison.

[ tglx: Use a proper commit reference instead of full SHA ]

Signed-off-by: Nikolas Nyby <nikolas@xxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Link: https://lkml.kernel.org/r/20190724041337.8346-1-nikolas@xxxxxxx

---
arch/x86/kernel/crash.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 2bf70a2fed90..eb651fbde92a 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -225,8 +225,6 @@ static int elf_header_exclude_ranges(struct crash_mem *cmem)
if (crashk_low_res.end) {
ret = crash_exclude_mem_range(cmem, crashk_low_res.start,
crashk_low_res.end);
- if (ret)
- return ret;
}

return ret;