Re: [PATCH v4 1/3] driver core: platform: Add an error message to platform_get_irq*()

From: Markus Elfring
Date: Wed Jul 24 2019 - 11:01:19 EST


> Let's consolidate all these error messages into the API itself,
> allowing us to get rid of the error messages in each driver.

Such information from the commit descriptions sounds positive.


> +++ b/drivers/base/platform.c
â
> @@ -163,6 +158,22 @@ int platform_get_irq(struct platform_device *dev, unsigned int num)
â
> +/**
> + * platform_get_irq - get an IRQ for a device
> + * @dev: platform device
> + * @num: IRQ number index
> + */

Do you find the provided description for the programming interface
really sufficient then?
Would it be more helpful to indicate the existence of an appropriate error message
also in this software documentation (besides the C source code)?

Regards,
Markus