[PATCH 5.2 410/413] pstore: Fix double-free in pstore_mkfile() failure path

From: Greg Kroah-Hartman
Date: Wed Jul 24 2019 - 15:42:47 EST

From: Norbert Manthey <nmanthey@xxxxxxxxx>

commit 4c6d80e1144bdf48cae6b602ae30d41f3e5c76a9 upstream.

The pstore_mkfile() function is passed a pointer to a struct
pstore_record. On success it consumes this 'record' pointer and
references it from the created inode.

On failure, however, it may or may not free the record. There are even
two different code paths which return -ENOMEM -- one of which does and
the other doesn't free the record.

Make the behaviour deterministic by never consuming and freeing the
record when returning failure, allowing the caller to do the cleanup

Signed-off-by: Norbert Manthey <nmanthey@xxxxxxxxx>
Link: https://lore.kernel.org/r/1562331960-26198-1-git-send-email-nmanthey@xxxxxxxxx
Fixes: 83f70f0769ddd ("pstore: Do not duplicate record metadata")
Fixes: 1dfff7dd67d1a ("pstore: Pass record contents instead of copying")
Cc: stable@xxxxxxxxxxxxxxx
[kees: also move "private" allocation location, rename inode cleanup label]
Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

fs/pstore/inode.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)

--- a/fs/pstore/inode.c
+++ b/fs/pstore/inode.c
@@ -318,22 +318,21 @@ int pstore_mkfile(struct dentry *root, s
goto fail;
inode->i_mode = S_IFREG | 0444;
inode->i_fop = &pstore_file_operations;
- private = kzalloc(sizeof(*private), GFP_KERNEL);
- if (!private)
- goto fail_alloc;
- private->record = record;
scnprintf(name, sizeof(name), "%s-%s-%llu%s",
record->psi->name, record->id,
record->compressed ? ".enc.z" : "");

+ private = kzalloc(sizeof(*private), GFP_KERNEL);
+ if (!private)
+ goto fail_inode;
dentry = d_alloc_name(root, name);
if (!dentry)
goto fail_private;

+ private->record = record;
inode->i_size = private->total_size = size;
inode->i_private = private;

if (record->time.tv_sec)
@@ -349,7 +348,7 @@ int pstore_mkfile(struct dentry *root, s