Re: [PATCH] extcon: max14577: Add irq mask IRQ_ONESHOT

[Krzysztof Kozlowski]

On Thu, 25 Jul 2019 at 08:42, Vasyl Gomonovych <gomonovych@xxxxxxxxx> wrote:
>
> Do not fire irq again until thread done
> This issue was found by code inspection
> Coccicheck irqf_oneshot.cocci

The same as in max77693 - this is virtual IRQ so no need for oneshot.
The hardware IRQ has oneshot set. Otherwise please provide slightly
more specific rationale for this commit.

Best regards,
Krzysztof

>
> Signed-off-by: Vasyl Gomonovych <gomonovych@xxxxxxxxx>
> ---
>  drivers/extcon/extcon-max14577.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index 32f663436e6e..97c021512ffc 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -698,7 +698,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
>
>                 ret = devm_request_threaded_irq(&pdev->dev, virq, NULL,
>                                 max14577_muic_irq_handler,
> -                               IRQF_NO_SUSPEND,
> +                               IRQF_NO_SUSPEND | IRQF_ONESHOT,
>                                 muic_irq->name, info);
>                 if (ret) {
>                         dev_err(&pdev->dev,
> --
> 2.17.1
>