Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET
From: Greg KH
Date: Thu Jul 25 2019 - 14:05:36 EST
On Wed, Jul 24, 2019 at 02:12:28PM -0700, David Miller wrote:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT)
>
> > From: YueHaibing <yuehaibing@xxxxxxxxxx>
> > Date: Wed, 24 Jul 2019 21:01:26 +0800
> >
> >> Now if CONFIG_ETHERNET is not set, QLGE driver
> >> building fails:
> >>
> >> drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
> >> drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev'
> >>
> >> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> >> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/")
> >> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> >
> > I'll let Greg take this.
>
> Actually, I take that back.
>
> Since the move to staging happened in my tree I will take this ;-)
Thanks. If you want to push that "move" to Linus soon, I can then take
any cleanup patches that show up for this driver, otherwise feel free to
ignore them until 5.4-rc1.
thanks,
greg k-h