Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device

From: Edward Cree
Date: Thu Jul 25 2019 - 14:06:04 EST

On 24/07/2019 23:47, David Miller wrote:
> From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 22 Jul 2019 19:26:35 +0200
>> Move from i2c_new_dummy() to i2c_new_dummy_device(). So, we now get an
>> ERRPTR which we use in error handling.
>> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Subject & description are incomplete, you're also changing i2c_new_device()
to i2c_new_client_device().
Other than that,
Acked-by: Edward Cree <ecree@xxxxxxxxxxxxxx>

> Solarflare folks, please review/test.
> Thank you.
Falcon isn't likely to get tested by us, I think we only have about three
Âof them left in the building, two of which are in display cabinets ;-)
We end-of-lifed this hardware a couple of years ago, maybe it should be
Âdowngraded from 'supported' to 'odd fixes'. Or even moved to staging,
Âlike that qlogic driver recently was.