Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps
From: Christoph Hellwig
Date: Thu Jul 25 2019 - 14:06:12 EST
On Wed, Jul 24, 2019 at 11:46:24AM -0700, John Stultz wrote:
> I'm still not understanding how this would work. Benjamin and Laura
> already commented on this point, but for a simple example, with the
> HiKey boards, the DRM driver requires contiguous memory for the
> framebuffer, but the GPU can handle non-contiguous. Thus the target
> framebuffers that we pass to the display has to be CMA allocated, but
> all the other graphics buffers that the GPU will render to and
> composite can be system.
But that just means we need a flag that memory needs to be contiguous,
which totally makes sense at the API level. But CMA is not the only
source of contigous memory, so we should not conflate the two.
> Laura already touched on this, but similar logic can be used for
> camera buffers, which can make sure we allocate from a specifically
> reserved CMA region that is only used for the camera so we can always
> be sure to have N free buffers immediately to capture with, etc.
And for that we already have per-device CMA areas hanging off struct
device, which this should reuse instead of adding another duplicate
CMA area lookup scheme.