Re: [PATCH] mfd: intel-lpss: Remove D3cold delay

From: Andy Shevchenko
Date: Thu Jul 25 2019 - 14:06:43 EST


On Thu, Jul 25, 2019 at 01:05:54PM +0100, Lee Jones wrote:
> On Tue, 09 Jul 2019, Andy Shevchenko wrote:
>
> > On Fri, Jul 05, 2019 at 12:55:03PM +0800, Kai-Heng Feng wrote:
> > > Goodix touchpad may drop its first couple input events when
> > > i2c-designware-platdrv and intel-lpss it connects to took too long to
> > > runtime resume from runtime suspended state.
> > >
> > > This issue happens becuase the touchpad has a rather small buffer to
> > > store up to 13 input events, so if the host doesn't read those events in
> > > time (i.e. runtime resume takes too long), events are dropped from the
> > > touchpad's buffer.
> > >
> > > The bottleneck is D3cold delay it waits when transitioning from D3cold
> > > to D0, hence remove the delay to make the resume faster. I've tested
> > > some systems with intel-lpss and haven't seen any regression.
> >
> > Thank you for the patch. I took it to our internal testing and will tell
> > the result within couple of weeks.
>
> Any news?

No bug reports, no negative feedback, I think we may proceed with it.
Thanks!

--
With Best Regards,
Andy Shevchenko