Re: [PATCH v2] ata/pata_buddha: Probe via modalias instead of initcall

[Max Staudt]

On 07/25/2019 07:33 PM, Max Staudt wrote:
> On 07/25/2019 07:03 PM, Bartlomiej Zolnierkiewicz wrote:
>> Please try to implement it, should be as simple as:
>>
>> static void pata_buddha_remove(struct zorro_dev *zdev)
>> {
>> 	struct ata_host *host = dev_get_drvdata(&zdev->dev);
>>
>> 	ata_host_detach(host);
>> }
>>
>> [ ata_host_alloc() in pata_buddha_probe() sets drvdata to host ]
> 
> Seeing as the driver is almost 1:1 the same as pata_gayle, I see no reason against this.
> 
> Do you need me to test module removal on the real machine, or is it okay to take your suggestion as-is, given that it is already accepted in pata_gayle?

Nevermind, I found a way to test it somewhat quickly. I can confirm that it works. Thanks for your suggestion!


Max