Re: [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values

[Andy Shevchenko]

On Wed, Jul 24, 2019 at 11:14 AM Rhys Kidd <rhyskidd@xxxxxxxxx> wrote:
>
> These values have already been defined in platform/x86/dell-smbios.h
>

Pushed to my review and testing queue, thanks!


> Signed-off-by: Rhys Kidd <rhyskidd@xxxxxxxxx>
> ---
>  drivers/platform/x86/dell-wmi.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 68a8a4eba4e3..fc33c38f5f82 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -311,13 +311,13 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
>         { KE_IGNORE, 0xfff1, { KEY_RESERVED } },
>
>         /* Keyboard backlight level changed */
> -       { KE_IGNORE, 0x01e1, { KEY_RESERVED } },
> -       { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
> -       { KE_IGNORE, 0x01e3, { KEY_RESERVED } },
> -       { KE_IGNORE, 0x02ea, { KEY_RESERVED } },
> -       { KE_IGNORE, 0x02eb, { KEY_RESERVED } },
> -       { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
> -       { KE_IGNORE, 0x02f6, { KEY_RESERVED } },
> +       { KE_IGNORE, KBD_LED_OFF_TOKEN,      { KEY_RESERVED } },
> +       { KE_IGNORE, KBD_LED_ON_TOKEN,       { KEY_RESERVED } },
> +       { KE_IGNORE, KBD_LED_AUTO_TOKEN,     { KEY_RESERVED } },
> +       { KE_IGNORE, KBD_LED_AUTO_25_TOKEN,  { KEY_RESERVED } },
> +       { KE_IGNORE, KBD_LED_AUTO_50_TOKEN,  { KEY_RESERVED } },
> +       { KE_IGNORE, KBD_LED_AUTO_75_TOKEN,  { KEY_RESERVED } },
> +       { KE_IGNORE, KBD_LED_AUTO_100_TOKEN, { KEY_RESERVED } },
>  };
>
>  static void dell_wmi_process_key(struct wmi_device *wdev, int type, int code)
> --
> 2.20.1
>


-- 
With Best Regards,
Andy Shevchenko