Re: [PATCH] fuse: BUG_ON's correction in fuse_dev_splice_write()

From: Miklos Szeredi
Date: Thu Aug 01 2019 - 07:02:09 EST


On Tue, Jul 23, 2019 at 8:33 AM Vasily Averin <vvs@xxxxxxxxxxxxx> wrote:
>
> commit 963545357202 ("fuse: reduce allocation size for splice_write")
> changed size of bufs array, so first BUG_ON should be corrected too.
> Second BUG_ON become useless, first one also includes the second check:
> any unsigned nbuf value cannot be less than 0.

This patch seems broken: it assumes that pipe->nrbufs doesn't change.
Have you actually tested it?

Thanks,
Miklos