Re: [PATCH v4] platform/chrome: cros_ec_trace: update generating script

From: Raul Rangel
Date: Thu Aug 01 2019 - 10:50:58 EST


On Thu, Aug 01, 2019 at 03:30:53PM +0200, Enric Balletbo i Serra wrote:

> Got it. I don't think this is a "kernel" way to do it. Also, I don't see a big
> value on doing this.

Code generation sounds great, but it makes finding and looking at the
source file difficult unless you have a build. It also makes Go to
definition in my editor fail to find the symbols since they don't exist
in the source tree.
>
> Note also that actually, we want:
>
> - cros_ec_commands (kernel) sync with ec_commands (EC firmware)
> - cros_ec_commands (kernel) sync with cros_ec_trace (kernel)
>
> Hopefully we will have all sync soon.

That would be great if you synced the commands from the EC firmware :)

Thanks