Re: [PATCH v2] platform/x86/pcengines-apuv2: use KEY_RESTART for front button

[Andy Shevchenko]

On Thu, Jul 25, 2019 at 10:06 PM Enrico Weigelt, metux IT consult
<info@xxxxxxxxx> wrote:
>
> From: Enrico Weigelt <info@xxxxxxxxx>
>
> The keycode KEY_RESTART is more appropriate for the front button,
> as most people use it for things like restart or factory reset.
>

Applied, thanks!

> Signed-off-by: Enrico Weigelt <info@xxxxxxxxx>
> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe ("x86: pcengines apuv2 gpio/leds/keys platform driver")

Please, use allowed minimum (12 nowadays) characters of hash.

> ---
>  drivers/platform/x86/pcengines-apuv2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index b0d3110..4138007c 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -93,7 +93,7 @@
>
>  static struct gpio_keys_button apu2_keys_buttons[] = {
>         {
> -               .code                   = KEY_SETUP,
> +               .code                   = KEY_RESTART,
>                 .active_low             = 1,
>                 .desc                   = "front button",
>                 .type                   = EV_KEY,
> --
> 1.9.1
>


-- 
With Best Regards,
Andy Shevchenko