Re: [PATCH net v2] mvpp2: fix panic on module removal

From: David Miller
Date: Thu Aug 01 2019 - 13:08:57 EST


From: Matteo Croce <mcroce@xxxxxxxxxx>
Date: Thu, 1 Aug 2019 14:13:30 +0200

> mvpp2 uses a delayed workqueue to gather traffic statistics.
> On module removal the workqueue can be destroyed before calling
> cancel_delayed_work_sync() on its works.
> Fix it by moving the destroy_workqueue() call after mvpp2_port_remove().
> Also remove an unneeded call to flush_workqueue()
...
> Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics")
> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> Signed-off-by: Matteo Croce <mcroce@xxxxxxxxxx>

Applied and queued up for -stable, thanks.