Re: [PATCH] mailmap: add entry for Jaegeuk Kim

[Jonathan Corbet]

On Fri, 2 Aug 2019 09:21:35 +0800
Chao Yu <yuchao0@xxxxxxxxxx> wrote:

> Add entry to connect all Jaegeuk's email addresses.
> 
> Acked-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> Signed-off-by: Chao Yu <yuchao0@xxxxxxxxxx>
> ---
>  .mailmap | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/.mailmap b/.mailmap
> index 477debe3d960..70d41c86e644 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -89,6 +89,9 @@ Henrik Kretzschmar <henne@xxxxxxxxxxxxxxxx>
>  Henrik Rydberg <rydberg@xxxxxxxxxxx>
>  Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
>  Jacob Shin <Jacob.Shin@xxxxxxx>
> +Jaegeuk Kim <jaegeuk@xxxxxxxxxx> <jaegeuk@xxxxxxxxxx>
> +Jaegeuk Kim <jaegeuk@xxxxxxxxxx> <jaegeuk@xxxxxxxxxxxx>
> +Jaegeuk Kim <jaegeuk@xxxxxxxxxx> <jaegeuk.kim@xxxxxxxxxxx>

So as I understand it, the mailmap file is there mostly to ensure that a
person's changesets are properly collected in 'git shortlog' and such.  As
documented on the man page, it is used when a person's name is spelled
differently at different times.

That doesn't appear to be the case here, and shortlog output is correct
already.  Given that, do we *really* need to maintain a collection of old
email addresses in the mailmap file?  What is the benefit of that?

Thanks,

jon