Re: [PATCH] net/mlx4_core: Use refcount_t for refcount
From: Chuhong Yuan
Date: Fri Aug 02 2019 - 22:43:01 EST
Saeed Mahameed <saeedm@xxxxxxxxxxxx> ä2019å8æ3æåå äå2:38åéï
> On Sat, 2019-08-03 at 00:10 +0800, Chuhong Yuan wrote:
> > Chuhong Yuan <hslester96@xxxxxxxxx> ä2019å8æ2æåä äå8:10åéï
> > > refcount_t is better for reference counters since its
> > > implementation can prevent overflows.
> > > So convert atomic_t ref counters to refcount_t.
> > >
> > > Also convert refcount from 0-based to 1-based.
> > >
> > It seems that directly converting refcount from 0-based
> > to 1-based is infeasible.
> > I am sorry for this mistake.
> Just curious, why not keep it 0 based and use refcout_t ?
> refcount API should have the same semantics as atomic_t API .. no ?
refcount API will warn when increase a 0 refcount.
It regards this as a use-after-free.