Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script for RHEL/CentOS

From: Alexander Kapshuk
Date: Sat Aug 03 2019 - 08:10:19 EST


On Sat, Aug 3, 2019 at 1:37 PM Mauro Carvalho Chehab
<mchehab+samsung@xxxxxxxxxx> wrote:
>
> Em Sat, 3 Aug 2019 13:31:30 +0300
> Alexander Kapshuk <alexander.kapshuk@xxxxxxxxx> escreveu:
>
> > > - if (! $system_release =~ /Fedora/) {
> > > + if (!($system_release =~ /Fedora/)) {
> > > $map{"virtualenv"} = "python-virtualenv";
> > > }
> >
> > The negated binding operator '!~' could be used here as well, and it
> > does not require the use of extra parenthesis.
> > Just a thought.
>
> Thanks for the tip! Never used such operator. Will start using
> next time we need to handle a pattern like that.
>
> Thanks,
> Mauro

No worries at all.