Re: [PATCH 6/6] arm64: dts: meson-g12b-khadas-vim3: add initial device-tree

[Martin Blumenstingl]

On Wed, Jul 31, 2019 at 2:44 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
[...]
> +       memory@0 {
> +               device_type = "memory";
> +               reg = <0x0 0x0 0x0 0x40000000>;
nit-pick: we typically use the memory size used in the board size with
the lowest amount of RAM - 2GiB in this case. so I would change it to
0x80000000

[...]
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               white {
> +                       label = "vim3:white";
downstream sources use label="sys_led"
should we call it vim3:white:sys?