Re: [PATCH 4/9] clk: qcom: Don't reference clk_init_data after registration

[Taniya Das]

On 8/1/2019 1:05 AM, Stephen Boyd wrote:
> A future patch is going to change semantics of clk_register() so that
> clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid
> referencing this member here so that we don't run into NULL pointer
> exceptions.
>
> Cc: Taniya Das <tdas@xxxxxxxxxxxxxx>
> Cc: Andy Gross <agross@xxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxx>


Acked-by: Taniya Das <tdas@xxxxxxxxxxxxxx>

> ---
>
> Please ack so I can take this through clk tree
>
>   drivers/clk/qcom/clk-rpmh.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index c3fd632af119..7a8a84dcb70d 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -396,6 +396,7 @@ static int clk_rpmh_probe(struct platform_device *pdev)
>   	hw_clks = desc->clks;
>   
>   	for (i = 0; i < desc->num_clks; i++) {
> +		const char *name = hw_clks[i]->init->name;
>   		u32 res_addr;
>   		size_t aux_data_len;
>   		const struct bcm_db *data;
> @@ -426,8 +427,7 @@ static int clk_rpmh_probe(struct platform_device *pdev)
>   
>   		ret = devm_clk_hw_register(&pdev->dev, hw_clks[i]);
>   		if (ret) {
> -			dev_err(&pdev->dev, "failed to register %s\n",
> -				hw_clks[i]->init->name);
> +			dev_err(&pdev->dev, "failed to register %s\n", name);
>   			return ret;
>   		}
>   	}

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--