Re: [PATCH] habanalabs: Update DRAM consumption on context tear down

From: Oded Gabbay
Date: Mon Aug 05 2019 - 03:17:30 EST


On Sun, Aug 4, 2019 at 10:03 AM Tomer Tayar <ttayar@xxxxxxxxx> wrote:
>
> The patch adds a missing update of the DRAM memory consumption, when a
> context is being torn down without an organized release of the allocated
> memory.
>
> Signed-off-by: Tomer Tayar <ttayar@xxxxxxxxx>
> ---
> drivers/misc/habanalabs/memory.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/misc/habanalabs/memory.c b/drivers/misc/habanalabs/memory.c
> index 42d237cae1dc..365fb0cb8dff 100644
> --- a/drivers/misc/habanalabs/memory.c
> +++ b/drivers/misc/habanalabs/memory.c
> @@ -1629,6 +1629,8 @@ void hl_vm_ctx_fini(struct hl_ctx *ctx)
> dev_dbg(hdev->dev,
> "page list 0x%p of asid %d is still alive\n",
> phys_pg_list, ctx->asid);
> + atomic64_sub(phys_pg_list->total_size,
> + &hdev->dram_used_mem);
> free_phys_pg_pack(hdev, phys_pg_list);
> idr_remove(&vm->phys_pg_pack_handles, i);
> }
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@xxxxxxxxx>
Applied to -fixed.
Thanks.
Oded