Re: [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies
From: Vignesh Raghavendra
Date: Mon Aug 05 2019 - 03:27:03 EST
On 19/07/19 1:59 PM, Vignesh Raghavendra wrote:
> On x86_64, when CONFIG_OF is not disabled:
>
> WARNING: unmet direct dependencies detected for MUX_MMIO
> Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n])
> Selected by [y]:
> - HBMC_AM654 [=y] && MTD [=y] && MTD_HYPERBUS [=y]
>
> due to
> config HBMC_AM654
> tristate "HyperBus controller driver for AM65x SoC"
> select MULTIPLEXER
> select MUX_MMIO
>
> Fix this by making HBMC_AM654 imply MUX_MMIO instead of select so
> that dependencies are taken care of. MUX_MMIO is optional for
> functioning of driver.
>
> Fixes: b07079f1642c ("mtd: hyperbus: Add driver for TI's HyperBus memory controller")
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>> ---
Applied to mtd/fixes.
> drivers/mtd/hyperbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/hyperbus/Kconfig b/drivers/mtd/hyperbus/Kconfig
> index cff6bbd226f5..1c691df8eff7 100644
> --- a/drivers/mtd/hyperbus/Kconfig
> +++ b/drivers/mtd/hyperbus/Kconfig
> @@ -15,7 +15,7 @@ if MTD_HYPERBUS
> config HBMC_AM654
> tristate "HyperBus controller driver for AM65x SoC"
> select MULTIPLEXER
> - select MUX_MMIO
> + imply MUX_MMIO
> help
> This is the driver for HyperBus controller on TI's AM65x and
> other SoCs
>
--
Regards
Vignesh