Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices()

[Hans de Goede]

Hi Jiri,

On 05-08-19 10:51, Jiri Kosina wrote:
> On Wed, 31 Jul 2019, Hans de Goede wrote:
>
> > > > > In delayedwork_callback(), logi_dj_recv_query_paired_devices
> > > > > may return positive value while success now, so check it
> > > > > correctly.
> > >
> > > > > Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of
> > > > > Fixes: logi_dj_recv_query_hidpp_devices")
> > > > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> > > > Reviewed-by: Petr Vorel <pvorel@xxxxxxx>
> > > OK, not only it didn't fix problems with logitech mouse (see below),
> > > but removing mouses USB dongle effectively crashes kernel, so this one
> > > probably
> > > shouldn't be applied :).
> > >
> > > [  330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with
> > > error 7
> > > [  331.462335] hid 0003:046D:C52F.0013: delayedwork_callback:
> > > logi_dj_recv_query_paired_devices error: 7
> >
> > Please test my patch titled: "HID: logitech-dj: Really fix return value of
> > logi_dj_recv_query_hidpp_devices"
> > which should fix this.
>
> Hans, have I been CCed on that patch? I don't seem to see it in in inbox.

I have "Jiri Kosina <jikos@xxxxxxxxxx>" in the To: for the patch in the
copy in my Inbox (I always Cc myself).

Anyways, you can grab it here:

https://patchwork.kernel.org/patch/11064087/

It has gathered 2 Tested-by-s and 2 Reviewed-by-s since posting, so
assuming you like it too, this is ready for merging.

Regards,

Hans