[PATCH v3 1/8] dma: debug: Replace strncmp with str_has_prefix
From: Chuhong Yuan
Date: Mon Aug 05 2019 - 08:22:34 EST
strncmp(str, const, len) is error-prone because len
is easy to have typo.
The example is the hard-coded len has counting error
or sizeof(const) forgets - 1.
So we prefer using newly introduced str_has_prefix()
to substitute such strncmp to make code better.
Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>
---
Changes in v3:
- Revise the description.
kernel/dma/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
index 099002d84f46..0f9e1aba3e1a 100644
--- a/kernel/dma/debug.c
+++ b/kernel/dma/debug.c
@@ -970,7 +970,7 @@ static __init int dma_debug_cmdline(char *str)
if (!str)
return -EINVAL;
- if (strncmp(str, "off", 3) == 0) {
+ if (str_has_prefix(str, "off")) {
pr_info("debugging disabled on kernel command line\n");
global_disable = true;
}
--
2.20.1