Re: [PATCH] regulator: core: Add of_node_put() before return

From: Markus Elfring
Date: Mon Aug 05 2019 - 08:31:04 EST


> +++ b/drivers/regulator/core.c
> @@ -380,9 +380,12 @@ static struct device_node *of_get_child_regulator(struct device_node *parent,
>
> if (!regnode) {
> regnode = of_get_child_regulator(child, prop_name);
> - if (regnode)
> + if (regnode) {
> + of_node_put(child);
> return regnode;
> + }
> } else {
> + of_node_put(child);
> return regnode;
> }
> }

I suggest to move common exception handling code to the end of
this function implementation.
Would you like to add a jump target like âput_nodeâ?

Regards,
Markus