Re: [PATCH v2 1/2] KVM: remove kvm_arch_has_vcpu_debugfs()

From: Paolo Bonzini
Date: Mon Aug 05 2019 - 11:48:21 EST


On 05/08/19 17:36, Greg KH wrote:
> On Sat, Aug 03, 2019 at 08:23:25AM +0200, Paolo Bonzini wrote:
>> On 31/07/19 20:55, Greg KH wrote:
>>> There is no need for this function as all arches have to implement
>>> kvm_arch_create_vcpu_debugfs() no matter what, so just remove this call
>>> as it is pointless.
>>>
>>> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>>> Cc: "Radim Krm" <rkrcmar@xxxxxxxxxx>
>>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>>> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>>> Cc: Borislav Petkov <bp@xxxxxxxxx>
>>> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
>>> Cc: <x86@xxxxxxxxxx>
>>> Cc: <kvm@xxxxxxxxxxxxxxx>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>>> ---
>>> v2: new patch in the series
>>
>> Let's remove kvm_arch_arch_create_vcpu_debugfs too for non-x86 arches.
>>
>> I'll queue your 2/2.
>
> Great, so what about 1/2? I have no objection to your patch for this.

I'll queue my own replacement of 1/2, together with your 2/2. Both
should reach Linus later this week.

Paolo