Re: [PATCH v6 28/57] pcie-gadget-spear: Remove dev_err() usage after platform_get_irq()

[Greg Kroah-Hartman]

On Wed, Jul 31, 2019 at 07:16:22AM -0700, Stephen Boyd wrote:
> Quoting Arnd Bergmann (2019-07-30 11:29:45)
> > On Tue, Jul 30, 2019 at 8:16 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> > >
> > > We don't need dev_err() messages when platform_get_irq() fails now that
> > > platform_get_irq() prints an error message itself when something goes
> > > wrong. Let's remove these prints with a simple semantic patch.
> > 
> > > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> > > ---
> > >
> > > Please apply directly to subsystem trees
> > 
> > The patch looks coorrect
> > 
> > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> > 
> > I wonder if we should just remove that driver though, it's been marked
> > as 'depends on BROKEN' since 2013, and it has never been possible
> > to compile it.
> 
> I'm happy to replace this patch with a deletion patch.
> 
> -----8<-----
> From: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> Subject: [PATCH] misc: Remove spear13xx pcie gadget driver
> 
> This driver has been marked broken since 2013, see commit 98097858ccf3
> ("misc: mark spear13xx-pcie-gadget as broken"). Let's remove this file
> now that it's been more than 5 years of existing in a broken state.
> 
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

Good idea, I've now queued up this deletion patch instead, thanks!

greg k-h