Re: [PATCH] NFC: nfcmrvl: fix gpio-handling regression
From: David Miller
Date: Mon Aug 05 2019 - 13:27:04 EST
From: Johan Hovold <johan@xxxxxxxxxx>
Date: Mon, 5 Aug 2019 12:00:55 +0200
> Fix two reset-gpio sanity checks which were never converted to use
> gpio_is_valid(), and make sure to use -EINVAL to indicate a missing
> reset line also for the UART-driver module parameter and for the USB
> driver.
>
> This specifically prevents the UART and USB drivers from incidentally
> trying to request and use gpio 0, and also avoids triggering a WARN() in
> gpio_to_desc() during probe when no valid reset line has been specified.
>
> Fixes: e33a3f84f88f ("NFC: nfcmrvl: allow gpio 0 for reset signalling")
> Cc: stable <stable@xxxxxxxxxxxxxxx> # 4.13
> Reported-by: syzbot+cf35b76f35e068a1107f@xxxxxxxxxxxxxxxxxxxxxxxxx
> Tested-by: syzbot+cf35b76f35e068a1107f@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
Applied and queued up for -stable.