Re: [PATCH net] mvpp2: fix panic on module removal

From: Matteo Croce
Date: Mon Aug 05 2019 - 14:18:19 EST


On Mon, Aug 5, 2019 at 7:58 PM David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Matteo Croce <mcroce@xxxxxxxxxx>
> Date: Wed, 31 Jul 2019 20:31:16 +0200
>
> > mvpp2 uses a delayed workqueue to gather traffic statistics.
> > On module removal the workqueue can be destroyed before calling
> > cancel_delayed_work_sync() on its works.
> > Fix it by moving the destroy_workqueue() call after mvpp2_port_remove().
>
> Please post a new version with the flush_workqueue() removed.

Hi,

I thought that it was already merged:

https://lore.kernel.org/netdev/20190801121330.30823-1-mcroce@xxxxxxxxxx/

Let me know if it's ok already.

Regards,
--
Matteo Croce
per aspera ad upstream