Re: [Intel-wired-lan] [PATCH 2/2] ixgbe: Use refcount_t for refcount

[Willem de Bruijn]

On Mon, Aug 5, 2019 at 5:43 PM Bowers, AndrewX <andrewx.bowers@xxxxxxxxx> wrote:
>
> > -----Original Message-----
> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On
> > Behalf Of Chuhong Yuan
> > Sent: Friday, August 2, 2019 3:55 AM
> > Cc: netdev@xxxxxxxxxxxxxxx; Chuhong Yuan <hslester96@xxxxxxxxx>; linux-
> > kernel@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; David S . Miller
> > <davem@xxxxxxxxxxxxx>
> > Subject: [Intel-wired-lan] [PATCH 2/2] ixgbe: Use refcount_t for refcount
> >
> > refcount_t is better for reference counters since its implementation can
> > prevent overflows.
> > So convert atomic_t ref counters to refcount_t.
> >
> > Also convert refcount from 0-based to 1-based.
> >
> > This patch depends on PATCH 1/2.
> >
> > Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>
> > ---
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +++---
> > drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.h | 2 +-
> >  2 files changed, 4 insertions(+), 4 deletions(-)
>
> Tested-by: Andrew Bowers <andrewx.bowers@xxxxxxxxx>

To reiterate, this patchset should not be applied as is. It is not
correct to simply change the initial refcount.