Re: [PATCH] fs/io_uring.c: convert put_page() to put_user_page*()

From: John Hubbard
Date: Mon Aug 05 2019 - 18:12:45 EST


On 8/5/19 3:05 PM, Ira Weiny wrote:
> On Mon, Aug 05, 2019 at 03:04:42PM -0700, 'Ira Weiny' wrote:
>> On Sun, Aug 04, 2019 at 07:32:06PM -0700, john.hubbard@xxxxxxxxx wrote:
>>> From: John Hubbard <jhubbard@xxxxxxxxxx>
>>>
>>> For pages that were retained via get_user_pages*(), release those pages
>>> via the new put_user_page*() routines, instead of via put_page() or
>>> release_pages().
>>>
>>> This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
>>> ("mm: introduce put_user_page*(), placeholder versions").
>>>
>>> Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
>>> Cc: Jens Axboe <axboe@xxxxxxxxx>
>>> Cc: linux-fsdevel@xxxxxxxxxxxxxxx
>>> Cc: linux-block@xxxxxxxxxxxxxxx
>>> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
>>
>> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> <sigh>
>
> I meant to say I wrote the same patch ... For this one...
>
> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
>

Hi Ira,

Say, in case you or anyone else is up for it: there are still about
two thirds of the 34 patches that could use a reviewed-by, in this series:

https://lore.kernel.org/r/20190804224915.28669-1-jhubbard@xxxxxxxxxx

...and even reviewing one or two quick ones would help--no need to look at
all of them, especially if several people each look at a few.

Also note that I'm keeping the gup_dma_core branch tracking the latest
linux.git, and it seems to be working pretty well, aside from one warning
that I haven't yet figured out (as per the latest commit):

git@xxxxxxxxxx:johnhubbard/linux.git


thanks,
--
John Hubbard
NVIDIA