Re: [PATCH 04/22] media: Move v4l2_fwnode_parse_link from v4l2 to driver base

From: Steve Longerbeam
Date: Tue Aug 06 2019 - 12:53:54 EST


Hi Andy,

On 8/5/19 11:41 PM, Andy Shevchenko wrote:
On Tue, Aug 6, 2019 at 2:37 AM Steve Longerbeam <slongerbeam@xxxxxxxxx> wrote:
There is nothing v4l2-specific about v4l2_fwnode_{parse|put}_link().
Make these functions more generally available by moving them to driver
base, with the appropriate name changes to the functions and struct.

In the process embed a 'struct fwnode_endpoint' in 'struct fwnode_link'
for both sides of the link, and make use of fwnode_graph_parse_endpoint()
to fully parse both endpoints. Rename members local_node and
remote_node to more descriptive local_port_parent and
remote_port_parent.

May I ask if it's going to be used outside of v4l2?

It could be, I can see fwnode_graph_parse_link() being useful in DRM, for example. But at this, only media core and v4l2 are making use of it.

This patch was created so that fwnode links can be parsed in a new media core function that forms media links from fwnode links.

The full patchset doesn't seem to be up yet, but see [1] for the cover letter.

Steve

[1] https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg148910.html