Re: [PATCH] ALSA: usb-midi: fix a memory leak bug

[Takashi Iwai]

On Wed, 07 Aug 2019 05:22:09 +0200,
Wenwen Wang wrote:
> 
> In __snd_usbmidi_create(), a MIDI streaming interface structure is
> allocated through kzalloc() and the pointer is saved to 'umidi'. Later on,
> the endpoint structures are created by invoking
> snd_usbmidi_create_endpoints_midiman() or snd_usbmidi_create_endpoints(),
> depending on the type of the audio quirk type. However, if the creation
> fails, the allocated 'umidi' is not deallocated, leading to a memory leak
> bug.
> 
> To fix the above issue, free 'umidi' before returning the error.
> 
> Signed-off-by: Wenwen Wang <wenwen@xxxxxxxxxx>

It's again a false-positive report.  The object is released
automatically by the destructor of its base snd_rawmidi object.


thanks,

Takashi