Re: [PATCH v2] selftests: kvm: Adding config fragments

[shuah]

Hi Naresh,

On 8/7/19 7:58 AM, Naresh Kamboju wrote:
> selftests kvm test cases need pre-required kernel configs for the test
> to get pass.

Can you elaborate and add more information on which tests fail without
these configs. I am all for adding configs, however I would like to
see more information explaining which tests don't pass without this
change.

> Signed-off-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
> ---
>   tools/testing/selftests/kvm/config | 3 +++
>   1 file changed, 3 insertions(+)
>   create mode 100644 tools/testing/selftests/kvm/config
>
> diff --git a/tools/testing/selftests/kvm/config b/tools/testing/selftests/kvm/config
> new file mode 100644
> index 000000000000..63ed533f73d6
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/config
> @@ -0,0 +1,3 @@
> +CONFIG_KVM=y
> +CONFIG_KVM_INTEL=y
> +CONFIG_KVM_AMD=y

That being said, it is up to Paolo to decide a call on this patch.

thanks,
-- Shuah