Re: [PATCH 09/15] mm: don't abuse pte_index() in hmm_vma_handle_pmd

From: Jason Gunthorpe
Date: Wed Aug 07 2019 - 13:18:07 EST


On Tue, Aug 06, 2019 at 07:05:47PM +0300, Christoph Hellwig wrote:
> pte_index is an internal arch helper in various architectures,
> without consistent semantics. Open code that calculation of a PMD
> index based on the virtual address instead.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> mm/hmm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

There sure are a lot of different ways to express this, but this one
looks OK to me, at least the switch from the PTRS_PER_PTE expression
in the x86 imlpementation to PMD_MASK looks equivalent

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>

Jason