Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code

From: Jarkko Sakkinen
Date: Wed Aug 07 2019 - 15:03:55 EST


On Tue, Aug 06, 2019 at 07:07:19PM +0530, Sumit Garg wrote:
> Move TPM2 trusted keys code to trusted keys subsystem.

Missing a long description. The reason is that it is better consolidate
all trusted keys code to a single location so that it can be maintained
sanely and it should be stated here.

> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> Signed-off-by: Sumit Garg <sumit.garg@xxxxxxxxxx>

I would suggest adding at least two commits before this:

- A commit that just exports tpm_buf stuff and TPM2 constants to
include/linux
- A commit that just changes the existing TPM 1.x trusted keys
code to use tpm_buf.

These should be before the current 1/3 commit.

/Jarkko