Re: [PATCHv5 06/37] alarmtimer: Provide get_timespec() callback

[Andrei Vagin]

On Wed, Aug 07, 2019 at 08:04:10AM +0200, Thomas Gleixner wrote:
> On Mon, 29 Jul 2019, Dmitry Safonov wrote:
> >  /**
> > @@ -869,8 +871,10 @@ static int __init alarmtimer_init(void)
> >  	/* Initialize alarm bases */
> >  	alarm_bases[ALARM_REALTIME].base_clockid = CLOCK_REALTIME;
> >  	alarm_bases[ALARM_REALTIME].get_ktime = &ktime_get_real;
> > +	alarm_bases[ALARM_REALTIME].get_timespec = posix_get_timespec,
> 
> That's just wrong:
> 
> >  /*
> >   * Get monotonic time for posix timers
> >   */
> > -static int posix_get_timespec(clockid_t which_clock, struct timespec64 *tp)
> > +int posix_get_timespec(clockid_t which_clock, struct timespec64 *tp)
> >  {
> >  	ktime_get_ts64(tp);
> >  	return 0;
> 
> Using a proper function name would have avoided this.

You are right. Will fix. Thanks!
>